Bugfix - Fix terminal opening in main dir for subtasks

[jutaz]

Ensures that terminal, when opened from a subtask, will open in a worktree if parent is also in a subtask. This just basically makes it more consistent as subtasks are part of the worktrees anyways.

[gemini-code-assist]

Summary of Changes

Hello @jutaz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where terminals launched for subtasks might not open in the expected directory. By introducing logic to check for and inherit a parent task's worktree when a subtask lacks its own, the change ensures that the terminal's current working directory is consistently aligned with the relevant project context, enhancing the user experience for managing tasks and subtasks.

Highlights

• Terminal CWD Fix for Subtasks: Terminals opened from subtasks will now correctly inherit their parent task's worktree as the current working directory if they don't define their own.
• ProjectManager Integration: The TerminalManager now depends on ProjectManager to facilitate the lookup of parent task worktrees.
• Comprehensive Testing: New unit tests have been added to validate the CWD resolution logic, covering various scenarios including tasks with their own worktrees, subtasks inheriting parent worktrees, and fallback to the base directory.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where terminals for subtasks were not opening in the parent's worktree directory. The logic to check for a parent's worktree when a subtask doesn't have its own is sound, and the change is well-supported by a comprehensive new test file. I have one minor suggestion to improve code clarity by removing an unnecessary optional chaining operator.

[gemini-code-assist]

The projectManager.getProject() method always returns a Project instance and is not nullable. Therefore, the optional chaining (?.) on the project variable is unnecessary. Removing it will make the code clearer and align it with the actual API contract.

Suggested change

	const project = this.projectManager.getProject(baseDir);
	const task = project?.getTask(taskId);
	if (task?.task.parentId) {
	const parentTask = project?.getTask(task.task.parentId);
	if (parentTask?.task.worktree) {
	worktree = parentTask.task.worktree;
	}
	}
	const project = this.projectManager.getProject(baseDir);
	const task = project.getTask(taskId);
	if (task?.task.parentId) {
	const parentTask = project.getTask(task.task.parentId);
	if (parentTask?.task.worktree) {
	worktree = parentTask.task.worktree;
	}
	}