Improved: logic to show inventory computation of other shipment items in an order (#396) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Jun 18, 2024
src/views/OrderDetail.vue
Outdated
| @@ -152,19 +152,27 @@ | |||
|
|
|||
| <ion-item lines="none" v-for="item in shipGroup.items" :key="item"> | |||
| <ion-thumbnail slot="start"> | |||
| <ShopifyImg :src="getProduct(item.productId).mainImageUrl" size="small"/> | |||
| <DxpShopifyImg :src="getProduct(item.productId).mainImageUrl" size="small"/> | |||
| </ion-thumbnail> | |||
| <ion-label> | |||
| <p class="overline">{{ getProductIdentificationValue(productIdentificationPref.secondaryId, getProduct(item.productId)) }}</p> | |||
| {{ getProductIdentificationValue(productIdentificationPref.primaryId, getProduct(item.productId)) ? getProductIdentificationValue(productIdentificationPref.primaryId, getProduct(item.productId)) : getProduct(item.productId).productName }} | |||
| <p>{{ translate("Color:", { color: getFeature(getProduct(item.productId).featureHierarchy, '1/COLOR') }) }}</p> | |||
There was a problem hiding this comment.
We should not display color and size, as we not displaying the same in product list item.
src/views/OrderDetail.vue
Outdated
Comment on lines
158
to
159
| <p class="overline">{{ getProductIdentificationValue(productIdentificationPref.secondaryId, getProduct(item.productId)) }}</p> | ||
| {{ getProductIdentificationValue(productIdentificationPref.primaryId, getProduct(item.productId)) ? getProductIdentificationValue(productIdentificationPref.primaryId, getProduct(item.productId)) : getProduct(item.productId).productName }} |
There was a problem hiding this comment.
Use the same pattern as used in Product list item card
| order.shipGroups?.find((shipGroup: any) => { | ||
| if(shipGroup.shipGroupSeqId === payload.shipGroupSeqId){ | ||
| shipGroup.items?.find((item: any) => { | ||
| if(item.productId === payload.productId) item.isFetchingStock = !item.isFetchingStock |
There was a problem hiding this comment.
Instead of adding this whole logic, we can simply update the item.isFetchingStock in the component method directly and then directly update the current order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#396
Short Description and Why It's Useful
Displayed inventory computation for the items in other shipments of an order.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance