Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toast messages and add missing static text entry in the locale file #394

Open
1 of 2 tasks
ymaheshwari1 opened this issue Jul 31, 2024 · 1 comment
Open
1 of 2 tasks
Assignees

Comments

@ymaheshwari1
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

On some places toast messages are confusing. Also there are multiple static labels those are missing from locale file.

This task also includes the alphabetic arrangement of locale file entries.

What are the acceptance criteria?

Add the suggested toast message for specific case in the comments section.

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information

@Adameddy26
Copy link

Adameddy26 commented Jul 31, 2024

@ymaheshwari1 Plz have a look at the suggestion mentioned below.
Current - Make sure you've reviewed the products and their counts before upload them for review.
Expected - Make sure you've reviewed the products and their counts before uploading them for review.

@R-Sourabh User is able to upload the CSV with no toast message on UI when selected column of CSV doesn't matches with the selected product identifier.

R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jul 31, 2024
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 14, 2024
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 14, 2024
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Aug 14, 2024
ymaheshwari1 added a commit that referenced this issue Aug 14, 2024
Improved: Update toast messages and add missing static text entry in the locale file(#394)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

No branches or pull requests

3 participants