Implemented: Ionic Date Time Picker inplace of Default Browser Date Time Picker #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoK2maan
reviewed
Aug 23, 2023
… case and created global css for date-selection modal (hotwax#186)
alsoK2maan
suggested changes
Aug 25, 2023
| @@ -0,0 +1,32 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Improve indentation, use 2 spaces
alsoK2maan
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #186
Short Description and Why It's Useful
Changes in orders and product-detail view.
Created a modal having ion-datetime and using it to pick a date.
Created a new function to open the date selection modal and change the filter based on the data received from the modal.
Screenshots of Visual Changes before/after (If There Are Any)
Before --
After --
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance