Implemented: product identifier component in settings page from dxp-components (dxp-178) #237
+338
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoK2maan
approved these changes
Sep 25, 2023
…n cases (dxp/178)
alsoK2maan
suggested changes
Oct 3, 2023
| // Get product identification from api using dxp-component and set the state if eComStore is defined | ||
| if (this.currentEComStore.productStoreId) { | ||
| await useProductIdentificationStore().getIdentificationPref(this.currentEComStore.productStoreId) | ||
| .catch((error) => console.error(error)); |
There was a problem hiding this comment.
Suggested change
| .catch((error) => console.error(error)); | |
| .catch((error) => console.error(error)); |
src/store/modules/user/actions.ts
Outdated
Comment on lines
77
to
80
| if (preferredStoreId){ | ||
| await useProductIdentificationStore().getIdentificationPref(preferredStoreId) | ||
| .catch((error) => console.error(error)); | ||
| } |
There was a problem hiding this comment.
We can move this logic above, where we are checking for preferredStoreId.
src/views/orders.vue
Outdated
| @@ -120,7 +120,7 @@ | |||
| <ShopifyImg :src="getProduct(item.productId).mainImageUrl" size="small"></ShopifyImg> | |||
| </ion-thumbnail> | |||
| <ion-label> | |||
| <h2>{{ item.parentProductName ? item.parentProductName :item.productName }}</h2> | |||
| <h2>{{ getProductIdentificationValue(productIdentificationPref.primaryId, item) }}</h2> | |||
There was a problem hiding this comment.
What if the selected primaryId is not available on the product?
| // Get product identification from api using dxp-component and set the state if eComStore is defined | ||
| if (payload.eComStore.productStoreId) { | ||
| await useProductIdentificationStore().getIdentificationPref(payload.eComStore.productStoreId) | ||
| .catch((error) => console.error(error)); |
There was a problem hiding this comment.
Suggested change
| .catch((error) => console.error(error)); | |
| .catch((error) => console.error(error)); |
Comment on lines
20
to
21
| <h4>{{ getProductIdentificationValue(productIdentificationPref.primaryId, currentVariant) }}</h4> | ||
| <p>{{ getProductIdentificationValue(productIdentificationPref.secondaryId, currentVariant) }}</p> |
There was a problem hiding this comment.
Please check if these changes are required or not.
…condition (dxp/178)
alsoK2maan
approved these changes
Oct 5, 2023
amansinghbais
changed the title
Ridwan6947
added a commit
to Ridwan6947/preorder
that referenced
this pull request
Jul 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related Issue: hotwax/dxp-components#178
Short Description and Why It's Useful
Improved the code to use the product identifier component implemented in dxp-components on the settings page.
Testing
The working of this code can be tested with the following pr: hotwax/dxp-components#192
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance