Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create a PixelDistribution from a sky footprint. #806

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

tskisner
Copy link
Member

@tskisner tskisner commented Feb 5, 2025

In most workflows, a PixelDistribution is created by passing through the detector pointing on each process and determining the locally hit pixels and submaps for a given pixelization scheme. This work adds support for creating a distribution from a pre-existing sky footprint. Each process will have the same hit submaps in this case. This is a stepping stone towards building the RHS out of core while keeping the locally hit pixels in node shared memory.

@tskisner tskisner requested a review from keskitalo February 5, 2025 16:48
@tskisner
Copy link
Member Author

tskisner commented Feb 5, 2025

Note: this PR also re-enables a couple tests that were accidentally disabled during tests.

In most workflows, a PixelDistribution is created by passing through
the detector pointing on each process and determining the locally
hit pixels and submaps for a given pixelization scheme.  This work
adds support for creating a distribution from a pre-existing sky
footprint.  Each process will have the same hit submaps in this case.
This is a stepping stone towards building the RHS out of core while
keeping the locally hit pixels in node shared memory.
Copy link
Member

@keskitalo keskitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do I understand correctly, that we have no submap support for rectangular pixelization?

@tskisner
Copy link
Member Author

Re: submaps:

  • The WCS projections in general support submaps, but this domain decomposition is just over the pixel index (so blocks of rows / columns in the projection). In practice this is not as useful as nested healpix submaps, since a typical scan strategy from the ground means that all processes essentially cross all submaps.
  • One could consider supporting a tiled scheme like pixell, and treat each tile as a submap. I don't see much technical benefit over healpix, but it is something we could support for compatibility reasons.
  • For the purposes of this PR and the footprint distribution helper function, a WCS projection is just assigned one submap (for the reasons above).

I'll work on the other fixes shortly.

@tskisner tskisner merged commit abb7bd0 into toast3 Feb 17, 2025
7 checks passed
@tskisner tskisner deleted the footprint branch February 17, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants