Large refactor of HDF5 support #897
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove compile-time dependency on libFLAC and use flacarray instead - Convert the existing version-1 HDF5 data format to use flacarray for low-level compression / decompression, while remaining backwards compatible with the existing on-disk group and dataset structure. - Define a new version (2) of the native HDF5 data format which makes use of flacarray and enforces consistent use of per-field compression parameters. This new version adds support for saving / loading arbitrary observation attributes, provided they define the save_hdf5() and load_hdf5() methods. - Fix Observation duplicate() and __eq__() methods to correctly handle arbitrary attributes which are more complicated class instances.
keskitalo
approved these changes
Dec 5, 2025
Member
keskitalo
left a comment
keskitalo
left a comment
There was a problem hiding this comment.
Massive body of work and with great added value. On what timescale do you intend to remove support for the older file format?
| if quanta is None and precision is None: | ||
| msg = "When compressing floating point data, you" | ||
| msg += " must specify the quanta or precision." | ||
| raise RuntimeError("You must specify the quanta") |
Member
There was a problem hiding this comment.
Probably intended to be raise RuntimeError(msg)
| ) | ||
|
|
||
|
|
||
| def save_instrument(parent_group, telescope, comm=None, session=None): |
Member
There was a problem hiding this comment.
Is this essentially implementing the save_hdf5() method for the instrument class? Where do we draw the line between classes that implement save_hdf5() and classes that have it implemented externally like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove compile-time dependency on libFLAC and use flacarray instead
Convert the existing version-1 HDF5 data format to use flacarray for low-level compression / decompression, while remaining backwards compatible with the existing on-disk group and dataset structure.
Define a new version (2) of the native HDF5 data format which makes use of flacarray and enforces consistent use of per-field compression parameters. This new version adds support for saving / loading arbitrary observation attributes, provided they define the save_hdf5() and load_hdf5() methods.
Fix Observation duplicate() and eq() methods to correctly handle arbitrary attributes which are more complicated class instances.