Baseline resource level for SLURM partition select #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have no guidance for what to look for, assume we want just one core. If more is needed, the user will need to specify, but they'd probably need to do that anyway; this is a best guess when told nothing!
dkfellows
added
bug
|
I'm not sure that it's the whole story - see #801 (comment) |
|
OK, now I understand what was wrong. When testing if a number of nodes/cores is matched, a |
|
The unit test added checks that, provided the partition configuration descriptors are right, we'll pick something sensible for a partition. It's not smart but it at least isn't floored by a task that doesn't ask for any resources any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have no guidance for what to look for, assume we want just one core. If more is needed, the user will need to specify, but they'd probably need to do that anyway; this is a best guess when told nothing!
I think this fixes #801