-
Notifications
You must be signed in to change notification settings - Fork 5
Support actions that render Jinja templates #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aplowman
wants to merge
43
commits into
develop
Choose a base branch
from
feat/templates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n or external executable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
actions
Related to usage, creation, documentation etc of task schema actions
enhancement
New feature or request
task-schemas
Related to task schema usage, creation, documentation, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes code in #857, which should be merged soon.
This includes the following changes made in support of new task schemas being developed for Gmsh/MOOSE integration in MatFlow, here:
input_files
toscript/program_data_in
. Currently it is only a subset of schemainputs
that can be passed.script/program_input_files
; a list ofinput_files
to pass to the script (via the format specified inscript/program_data_in
script/program_data_in
to make sure inputs are prefixed byinputs.
, unless they start withinput_files.
! This disambiguates the two but still allows specifying inputs without theinputs.
prefix, as is currently in use.Jinja template support:
TaskSchema
validation raises on incompatible schema inputs with respect to the Jinja template (missing and extra)Action.get_input_types
: check gets Jinja inputsAction.is_input_type_required
: check Jinja inputs included