-
Notifications
You must be signed in to change notification settings - Fork 5
Support running built-in or external "programs" #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aplowman
wants to merge
24
commits into
develop
Choose a base branch
from
feat/programs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n or external executable
Action.program(_path)
attribute for running a built-i…
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new attributes to
Action
that define running built-in or external executable "programs" (typically binary files). The immediate motivation for this is running compiled standalone Matlab applications (in particular compiled MTEX scripts).The
Action.program
attribute (which corresponds to running a built-in program) is similar to theAction.script
attribute, and shares some similar parametrisation. For examplescript_data_in/out
->program_data_in/out
. For external programs, theAction.program_path
attribute can be used. In future, I intend to reorganise the script-related code so built-in/external scripts are distinguished in this way as well.This PR also add three new
ElementResources
attributes:platform
,CPU_arch
, andexecutable_extension
, which cannot be set by the user but can be retrieved/referencde. The reason for adding these is so built-in programs can be organised by operating system type (i.e. theplatform
key, which takes values like "win" for Windows, "linux", and "macos").executable_extension
is.exe
on Windows, and empty on other platforms.This PR also includes an unrelated fix in how we store run IDs associated with jobscript blocks. We were storing run IDs as unsigned integers, but then expected signed integers elswhere, which caused problems (most obviously in the
show
command, for task schemas that have conditional actions)!