Fix/fit_single_crystal_parameters demo #458
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #445
This demo submits and runs fine in the develop build, however, when looking at the post-processed result, the model cannot converge on the right single crystal parameters, as shown in the plot:

First things first, the necking region is included in the data - surely this is affecting the convergence? In commit 3dae49b I've removed this necking region from the data.
@aplowman has already also fixed one part - the jacobian in formable:
This makes the simulation actually start to converge:

However there is another problem - sensible parameter bounds have to be put into the code so that when searching the parameter space, parameters can't go negative as appears to be happening for the CRSS: