fix codefactor issues

app/controllers/users_controller.rb

@@ -30,7 +30,7 @@ def update
   def update_role
     @user = User.find(params[:id])
     @user.update(role: params[:role])
-    redirect_to  users_path
+    redirect_to users_path
   end
 
   private

app/helpers/users_helper.rb

@@ -3,14 +3,15 @@
 module UsersHelper
   def last_admin?(user)
     user.admin? &&
-        is_current_user?(user) &&
-        only_one_admin?
+      current_user?(user) &&
+      only_one_admin?
   end
+
   def only_one_admin?
     User.all.select(&:admin?).size == 1
   end
 
-  def is_current_user?(user)
+  def current_user?(user)
     user == current_user
   end
 end

app/views/users/edit.html.erb

@@ -23,7 +23,7 @@
       <td>Name</td>
       <td><%= @user.name %></td>
     </tr>
-    <% if @user == current_user %>
+    <% if current_user?(@user) %>
       <tr>
         <td><%= User.human_attribute_name('ssh_key') %></td>
         <td><%= f.text_area :ssh_key, class: 'form-control', rows: '8', id: 'sshKeyField' %></td>

spec/factories/users.rb

@@ -7,7 +7,7 @@
   factory :user do
     # https://github.com/stympy/faker/blob/master/doc/v1.9.1/internet.md#fakerinternet
     email { Faker::Internet.safe_email }
-    password { Faker::Internet.password(min_length = 10, max_length = 20, mix_case = true, special_chars = true) }
+    password { Faker::Internet.password(10, 20, true, true) }
     password_confirmation { password }
     first_name { 'Max' }
     last_name { 'Mustermann' }

spec/features/users/index.html.erb_spec.rb

@@ -19,7 +19,7 @@
       before do
         @button_user = page.find(id: "btn-user-#{user.id}")
         @button_employee = page.find(id: "btn-employee-#{user.id}")
-        @button_admin= page.find(id: "btn-admin-#{user.id}")
+        @button_admin = page.find(id: "btn-admin-#{user.id}")
       end
 
       it 'shows that the role is user' do
@@ -65,7 +65,7 @@
       before do
         @button_user = page.find(id: "btn-user-#{employee.id}")
         @button_employee = page.find(id: "btn-employee-#{employee.id}")
-        @button_admin= page.find(id: "btn-admin-#{employee.id}")
+        @button_admin = page.find(id: "btn-admin-#{employee.id}")
       end
 
       it 'shows that the role is employee' do
@@ -111,7 +111,7 @@
       before do
         @button_user = page.find(id: "btn-user-#{admin.id}")
         @button_employee = page.find(id: "btn-employee-#{admin.id}")
-        @button_admin= page.find(id: "btn-admin-#{admin.id}")
+        @button_admin = page.find(id: "btn-admin-#{admin.id}")
       end
 
       it 'shows that the role is admin' do
@@ -170,7 +170,7 @@
           visit users_path
           @button_user = page.find(id: "btn-user-#{admin.id}")
           @button_employee = page.find(id: "btn-employee-#{admin.id}")
-          @button_admin= page.find(id: "btn-admin-#{admin.id}")
+          @button_admin = page.find(id: "btn-admin-#{admin.id}")
         end
 
         it 'disables no button' do

spec/views/users/show.html.erb_spec.rb

@@ -6,7 +6,6 @@
   let(:user) { FactoryBot.create :user }
   let(:current_user) { FactoryBot.create :user }
 
-
   before do
     allow(view).to receive(:current_user).and_return(current_user)
     assign(:user, user)