Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage user roles #110

Closed
6 tasks done
isabel-amon opened this issue Nov 28, 2018 · 6 comments
Closed
6 tasks done

manage user roles #110

isabel-amon opened this issue Nov 28, 2018 · 6 comments
Assignees

Comments

@isabel-amon
Copy link

isabel-amon commented Nov 28, 2018

Beschreibung
As an admin I want to be able to manage the rights of the users of our tool, so that everyone can use the functionalities he/she needs. On a all-users page I want to see a grouped toggle button (see screenshot below) with the options of user, employee and admin. The current role of the user should be pressed down so I can see it clearly.
When I click on a role the user not currently has, I want his or her role changed accordingly.

screen shot 2018-12-19 at 2 27 16 pm

I only want to be able to change my own role, if there is still one other admin left after I do so, in order to avoid there being no admin left. In this case the other options next to my name in my grouped button should be greyed out and not clickable.

Akzeptanzkriterien

  • A grouped button exists on the all-users-page, displaying the users current role
  • This button is only visible for admins
  • Pressing another role changes the role of the according user
  • After the change happened the user gets access to the tool according to his new role
  • An admin can only change his/her own role if ensured that there is at least one other admin left
  • If no other admin would be left, the last admins other role buttons are not clickable

Priorität

Aufwandsschätzung

@skydivin4ng3l
Copy link
Contributor

depends on #77

@lassesteffen
Copy link
Contributor

lassesteffen commented Dec 21, 2018

  • add a button group to the users page in a role column
  • show selected role
  • make this only visible for admins
  • make the role changeable by clicking on the button
  • grey out button options for the admin if there is only one admin
  • make the buttons unclickable in the former case
  • get admin edit working
  • add test if there is only one vs multiple admins
  • edit add check that there would be no vm unattended if employee is degraded
  • add tests for the former

@lassesteffen
Copy link
Contributor

Before an employee is degraded to user, there is a check making sure no vm is left without any responsible people

@isabel-amon is this already implemented? I can not see it being implemented and this is the only thing keeping from closing this issue. If it possible to move this into a seperate issue, so we can deploy this feature?

@isabel-amon
Copy link
Author

sorry for the late answer, since this issue is closed now is everything clear? this was not implemented and should be implemented by you, I can move it into a separate issue if you still like.

@lassesteffen lassesteffen reopened this Jan 3, 2019
@lassesteffen
Copy link
Contributor

It was not done, wasnt careful with github references. You can see in my task list, that the last two options are not taken care of right now. I just thought we might be able to move them in a new issue, so we can actually close this one.

@isabel-amon
Copy link
Author

Moved the task in #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants