Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

110 Better manage user roles #200

Merged
merged 11 commits into from
Dec 29, 2018
Merged

110 Better manage user roles #200

merged 11 commits into from
Dec 29, 2018

Conversation

lassesteffen
Copy link
Contributor

Fixes #110

@lassesteffen lassesteffen added the WIP work is still in progess for this PR label Dec 14, 2018
@lassesteffen lassesteffen force-pushed the 110/login/manage-user-roles branch 2 times, most recently from 8bf0251 to 1617b16 Compare December 21, 2018 16:03
Copy link
Contributor

@mlichtblau mlichtblau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 request and 1 suggestion :)

app/helpers/users_helper.rb Outdated Show resolved Hide resolved
app/views/users/index.html.erb Outdated Show resolved Hide resolved
spec/factories/users.rb Show resolved Hide resolved
app/controllers/users_controller.rb Show resolved Hide resolved
@lassesteffen
Copy link
Contributor Author

@mlichtblau I implemented the suggestions, would be nice if I could get another review

@lassesteffen lassesteffen merged commit 6963fd4 into dev Dec 29, 2018
@lassesteffen lassesteffen deleted the 110/login/manage-user-roles branch December 29, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP work is still in progess for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants