More lua integration work (proof-of-concept) #20851
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Hm, looks like we'll have to build armips (the assembler) for libretro as well, if we want to support lua there.... |
hrydgard
force-pushed
the
lua-work
branch
2 times, most recently
from
06610f9 to
b836594
Compare
Owner
Author
|
ugh, an ElfTypes.h include path conflict (we have two of them, one in armips and one for ppsspp). |
hrydgard
force-pushed
the
lua-work
branch
2 times, most recently
from
cb067bf to
6737635
Compare
…g what's missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply makes the plugin system support lua, and adds a whole bunch of functionality to our lua contexts. Note: Hook functionality is still missing so all you can really do with this is binary patches on startup currently, and print to the log.
Unfortunately I've ran into the issue now that you can't safely save/load a complete lua state, it's just not possible to do the way they're designed. But we can probably approximate it well enough by reloading scripts on save state load, and saving/restoring any global variables on top. It will be pretty complicated now and the plugins will need to be aware of some restrictions.