Fix printing interfaces on node18

[alexanderankin]

Changes minor logging output issue

Relevant issues

Fixes #810

Contributor checklist

• Provide tests for the changes (unless documentation-only)
• Documented any new features, CLI switches, etc. (if applicable)
  • Server --help output
  • README.md
  • doc/http-server.1 (use the same format as other entries)
• The pull request is being made against the master branch

Maintainer checklist

• Assign a version triage tag
• Approve tests if applicable

[lygstate]

better to testing with nodejs 18

[dvtate]

lgtm, although I'd just add a check for || details.family === 4 on 229 for simplicity

[alexanderankin]

I would say that this adds clarity right -- code is not just read by computers but also by humans, and node 16 will be EOL at some point, and then this could simply be removed again (but only if its clear that it is a node <= 18 thing). I believe I've granted the maintainers access to the branch, so they can make simplifications as they see fit before merging.

[thornjad]

Thank you for the PR! And for the write access! I just added a small comment. I'm going to add Node 18 testing to master, merge that in, let tests run, then merge

[thornjad]

It would actually be much easier for you to merge in latest master than me, could you whenever you get a chance?

[alexanderankin]

Should be able to do that tonight

…

On Tue, May 31, 2022, 6:09 PM Jade Michael Thornton < ***@***.***> wrote: It would actually be much easier for you to merge in latest master than me, could you whenever you get a chance? — Reply to this email directly, view it on GitHub <#811 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACECGJE5R2VQ46W2C3L3CGLVM2E2ZANCNFSM5VNJVFOQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[alexanderankin]

merged and pushed

[alexanderankin]

@thornjad - its merged, in case you missed it

[alexanderankin]

@thornjad - master has been merged

[dvtate]

@thornjad it's been over a month,,,;.;

[dvtate]

Maintainer is asking for funding but hasn't touched this repo all summer (~3 months)

[dvtate]

It seems that this PR is now only needed to support nodejs v18.0.0 - v18.4.0 as they've reverted the change. Would update the version numberrs in the pr.

[jelveh]

Hello all,

I appreciate everybody chiming in on this PR. It's been more than three years since this PR was active, and based on my experience, it's pretty difficult to revive and update a PR after such a long time for a variety of reasons: contributors move on, context is lost, merge conflicts happen, etc. So I decided to create a new PR (#926) to resolve this issue and close this one. We appreciate everybody who contributes to this awesome project and we'll do our best to follow up on issues and PRs as quickly as possible moving forward.

Best,
Nariman