Only run unusedCompileDependenciesTest on the JVM#128
Closed
rossabaker wants to merge 1 commit intomainfrom
Closed
Only run unusedCompileDependenciesTest on the JVM#128rossabaker wants to merge 1 commit intomainfrom
rossabaker wants to merge 1 commit intomainfrom
Conversation
Member
|
I'm not sure this will help us. The CI workflow is global to the whole build, not per-project. What could help is if we added a conditional to this step that only runs if it is a JVM job. But this gets fiddly if we try and account for pure JVM (like the jdk client) or pure JS projects (like dom). |
Member
|
I know it doesn't help us right now, but what we |
Member
|
I have a fix incoming. Edit: |
Member
Author
|
Oh, I thought this would run only on the JVM, but I did bake in an assumption everything was using cross project, which is probably not right. |
Member
Author
|
#129 is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help with http4s/http4s#5926.