[SP] fix loss computation example #3858
Merged
+13
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
will need a patch for this i believe |
Member
|
Indeed, I will do a patch early next week if this is fine ! |
SunMarc
reviewed
Nov 28, 2025
Comment on lines
-1639
to
-1640
| if self.parallelism_config.sp_backend == "deepspeed": | ||
| # deepspeed handles cp in a different way, configured in _prepare_deepspeed |
Member
There was a problem hiding this comment.
prepare_cp is only called when cp_enabled no ? this shouldn't impact I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix the SP loss example based on huggingface/transformers#42444
add a fix for CP as reported by #3817 (comment) by @egangu
Fixes #3856
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.