Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tflops_tolerance is based from the fastest GPU #1

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

glutamatt
Copy link
Member

No description provided.

@glutamatt glutamatt marked this pull request as ready for review January 29, 2025 17:45
@glutamatt glutamatt changed the title tflops_tolerance is based from the faster GPU tflops_tolerance is based from the fastest GPU Jan 29, 2025
Copy link
Member

@Hugoch Hugoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Ratio to best performing GPU makes more sense than comparing avg.

@glutamatt glutamatt requested a review from Hugoch January 30, 2025 09:04
@Hugoch Hugoch merged commit ca39a94 into huggingface:main Feb 17, 2025
2 of 3 checks passed
@glutamatt glutamatt deleted the minmaxtolerance branch February 17, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants