Accept version specifications for kernels in pyproject.toml
#11
Conversation
We lock the highest compatible version. Until we have a better mechanism, tags of the form `vX.Y.Z` are recognized as versions. The versions are locked by their git commit SHA.
| https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers | ||
| """ | ||
| versions = _get_available_versions(repo_id) | ||
| requirement = SpecifierSet(version_spec) |
There was a problem hiding this comment.
This seems to be accepting a lot more that pure version specifiers.
https://packaging.python.org/en/latest/specifications/version-specifiers/#direct-references
But seems to convenient to pass on for now :).
Do you happen to know if it also supports the "extensions" (not sure about the proper terminology) "0.1.0; python_version> '3.9'"
There was a problem hiding this comment.
Seems like they are called markers, but they are only parsable when using Requirement, but that also includes the package name, etc.:
https://packaging.pypa.io/en/latest/requirements.html
I think we could easily support this in the future if we want to (by stubbing the package name and then parsing everything as a requirement).
There was a problem hiding this comment.
I was thinking reducing what we accept for now (just about controlling the actual surface of what people will try to do and the errors they receive).
But again no need to reinvent the wheel here.
We lock the highest compatible version. Until we have a better mechanism, tags of the form
vX.Y.Zare recognized as versions. The versions are locked by their git commit SHA.