-
Notifications
You must be signed in to change notification settings - Fork 367
Add MAGI-1 library #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add MAGI-1 library #1386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jiahy0825 - Thanks for the PR, couple of quick notes:
- I see that instead of one model per repo, there are multiple different models in the same repo: https://huggingface.co/sand-ai/MAGI-1/tree/main/ckpt/magi
- Since all the model repos are diffusers repos, the download tracking should automatically work if these checkpoints were split in 3 repos.
Let me know if you have any questions.
Hi, thanks a lot for your reply! We would like to keep all these models in a single repo because our model pipeline is relatively complex — it involves multiple components like T5, VAE, and others. Having all related models organized within one repo would make it much easier for users to find and use them together. Therefore, we would prefer to track downloads through this repo via the PR if possible. Please let me know if you have any better suggestions. Thanks again for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case I'd defer to @Wauplin if we can make an exception. In general, we do strongly recommend having separate repos for separate models!
This PR adds MAGI-1 library