No more text2text
#1590
Open
No more text2text
#1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heads up this is pure vibe-coding _pre-LLM_, i.e. I'm not sure what I'm doing but I'm still doing it, manually (though I tried to take inspiration from #457) The goal is to address https://discuss.huggingface.co/t/no-0-models-returned-by-text2text-search-filter/161546 following huggingface-internal/moon-landing#14258
Pierrci
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca,
ngxson and
hanouticelina
as code owners
|
just dropping this here, anyone feel free to push on top of it x) |
Wauplin
approved these changes
Jul 3, 2025
| @@ -1,7 +1,6 @@ | |||
| import type { TaskDataCustom } from "../index.js"; | |||
|
|
|||
| const taskData: TaskDataCustom = { | |||
| canonicalId: "text2text-generation", | |||
There was a problem hiding this comment.
shouldn't we replace by
canonicalId: "text-generation",?
There was a problem hiding this comment.
well no, because since those examples were created, we added dedicated pipelines for both summarization and translation, iiuc, cc @SBrandeis
or is it not how it works? ^^'
| @@ -1,7 +1,6 @@ | |||
| import type { TaskDataCustom } from "../index.js"; | |||
|
|
|||
| const taskData: TaskDataCustom = { | |||
| canonicalId: "text2text-generation", | |||
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heads up this is pure vibe-coding pre-LLM, i.e. I'm not sure what I'm doing but I'm still doing it, manually (though I tried to take inspiration from #457)
The goal is to address https://discuss.huggingface.co/t/no-0-models-returned-by-text2text-search-filter/161546 following https://github.com/huggingface-internal/moon-landing/pull/14258