Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ddp_timeout argument in SFTConfig to avoid timeout error(issue #160) #513

Closed
wants to merge 0 commits into from

Conversation

HowToNameMe
Copy link

fix issue #160

@edbeeching
Copy link
Collaborator

hi @HowToNameMe . Thanks for your PR, I am not sure how just adding this to the config resolves the issue. Do you not need to set a var somewhere? Or does this override a default value?

@HowToNameMe
Copy link
Author

HowToNameMe commented Mar 24, 2025

@edbeeching Thanks for your review. The issue #160 happens when NCCL fails out of the ddp timeout. The parameter corresponding to ddp timeout is in the transformers repository and not exposed to the developers of open-r1. To tackle this issue, we need to add the ddp_timeout to the SFTConfig and override the default value in transformers(30 minutes) with 24 hours.

@edbeeching
Copy link
Collaborator

@HowToNameMe , SFTConfig is a child class of TrainingArguments, so you should be able to set this option at the command line / config file.

@HowToNameMe
Copy link
Author

@edbeeching Thanks for your guidance. It is possible to override the ddp_timeout in command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants