refactor: extract shared config options into mixin to reduce duplication - #724
Open
devhemanthac-commits wants to merge 1 commit into
Open
refactor: extract shared config options into mixin to reduce duplication#724devhemanthac-commits wants to merge 1 commit into
devhemanthac-commits wants to merge 1 commit into
Conversation
- Create SharedTrainingConfig mixin containing common training options - GRPOConfig and SFTConfig now inherit from SharedTrainingConfig - Eliminates duplicate field definitions between the two config classes - Improves maintainability and reduces risk of config drift Resolves TODO at line 123 in configs.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves TODO at line 123 in configs.py