-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: experiment with swift-format for PR #174
base: main
Are you sure you want to change the base?
Conversation
@FL33TW00D, maybe try a line length of 120, which might result in fewer changes and looks better to my eye. If it's making too many changes that are not to your taste, it might be because it's applying default settings that you can override by specifying rules. |
@DePasqualeOrg if you have any suggestions on config to try and minimize changes that would be great! The main one for me is how to disable adding |
It looks like the I don't care too much about specific rules, as long as they don't make the code harder to read. I find the 100-character line length makes the code less readable, and I have my configuration files set to 120 for that reason. |
@DePasqualeOrg Updated to 120 line length. This can be tested locally with
|
Of course the best time to start using formatting would have been at the beginning of the project, to avoid having changes later on. But I think the benefits of having automated formatting outweigh any drawbacks (that I'm aware of) of this one-time change. |
After discussions with @ZachNagengast, it seems that nicklockwoods I'd be happy to format the whole repo using this, but will defer to @pcuenca for confirmation. Thanks @ZachNagengast! |
swift-format
seems quite heavy handed.