-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable qwen2vl video #2756
Open
drbh
wants to merge
54
commits into
main
Choose a base branch
from
enable-qwen2vl-video
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable qwen2vl video #2756
Changes from 52 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
18c9f06
WIP video support
mfarre 7c67939
router changes
mfarre 5ced960
adopting video url
mfarre 05464d2
connecting video to qwen2
mfarre c7c2fda
fix
mfarre b9c8152
downloading videos
mfarre 464609f
fix
mfarre a25c3ec
refactoring
mfarre 3c07391
fix
mfarre b2c5575
feat: support video input chunks and enable qwen2 vl to process video
drbh 83a7f18
fix: add protobuf update and mp4parse dep
drbh 322165d
fix: remove unused deps and imports
drbh e65ead1
moving video sampling and resize to validation. downstream we receive…
mfarre 36e095b
flatten frames to data block when needed
mfarre bc5e202
fix: adjust video process, reduce to 1 fps and adjust tensor shape
drbh 1afaa69
fix: adjust deps after rebase
drbh 16007b6
feat: adjust impure shell deps and autodocs workflow
drbh 39fac7e
fix: include more deps for ffmpeg as docs suggest
drbh b508b10
fix: add ffmpeg deps to test build
drbh 4a3a724
fix: debug ffmpeg install in tests workflow
drbh ac7483c
fix: debug ffmpeg deps in tests II
drbh 137f3bb
fix: adjust dependencies and bump pip along with python
drbh daf83a9
fix: adjust pkg config in test
drbh d5cc670
fix: ensure pip is installed after installing deps in test workflow
drbh 4a76e8b
fix: add libavfilter dep to test
drbh f0c3841
fix: add libavdevice dep to tests workflow
drbh 96968a0
fix: add ffmpeg overlay and enable build
drbh 167c6f0
fix: include ffmpeg deps in autodocs workflow
drbh 98392a7
Cleanup impure Nix shell
danieldk 05004a6
Make the pure build work
danieldk 063104c
Fix test devshell
danieldk 2dc078a
fix: bump deps in other dockerfiles
drbh 50b5399
fix: add ffmpeg to final layer of container
drbh b5b2184
fix: include usr lib in ld path
drbh 75ab887
fix: copy shared libraries from builder
drbh cbf1d98
installing ssl requirements prior to rust building stage
mfarre af77a0c
fixing ssl issue
mfarre 19e1c8d
working version
mfarre db97d97
cleanup prints
mfarre 71ed75a
fix: pre commit and clippy lints
drbh e2b75a5
fix: resolve rebase issues and add test
drbh 1d6bf24
fix: remove unnecessary cast
drbh 2ae152a
fix: update all vlm forward args, pass shared libraries to final laye…
drbh 5c7bc91
fix: adjust batch_tokenized_inputs output in mllama
drbh bb00fb3
fix: update lints after rebase
drbh 91ed362
fix: update trtllm dockefile after rebase
drbh 5322abd
fix: adjust whitespace lint
drbh b4da6ad
fix: feature flag video and remove from non cuda dockerfiles
drbh 27f758d
fix: make ffmpeg-next dep optional with feature
drbh 4f42d0c
fix: include the video feature in cargo chef command
drbh dcc1194
fix: adjust trtllm looper for video chunk enum
drbh b27749e
fix: small refactor and cleanups
drbh 78cd756
fix: improve video processing and update unsupported paths
drbh 17192c9
fix: remove test debug params
drbh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,9 @@ jobs: | |
- name: Install | ||
run: | | ||
sudo apt update | ||
sudo apt install python3.11-dev -y | ||
sudo apt install python3.11-dev python3.11-venv python3-pip clang libavcodec-dev libavfilter-dev libavdevice-dev libavformat-dev libavutil-dev pkg-config -y | ||
export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:/usr/lib/x86_64-linux-gnu/pkgconfig | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not env shenanigans |
||
python -m pip install --upgrade pip | ||
make install-cpu | ||
- name: Run server tests | ||
run: | | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No dev packages please (we shouldn't need them most likely).
Why is clang in there?