-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initial qwen2.5-vl model and test #2971
Conversation
1adfee4
to
e9b5806
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
17c93ff
to
1f58577
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
transformers = python-super.transformers.overrideAttrs ( | ||
_: _: { | ||
src = final.fetchFromGitHub { | ||
owner = "huggingface"; | ||
repo = "transformers"; | ||
rev = "8d73a38606bc342b370afe1f42718b4828d95aaa"; | ||
hash = "sha256-MxroG6CWqrcmRS+eFt7Ej87TDOInN15aRPBUcaycKTI="; | ||
}; | ||
} | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need that with 4.49 release ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be able to be removed with 4.49
} | ||
|
||
|
||
class Qwen2_5_VLProcessor(ProcessorMixin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not defined in transformers
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was added in 4.49 so can be be removed with the update too
if ( | ||
self.model.config.model_type == "qwen2_vl" | ||
or self.model.config.model_type == "qwen2_5_vl" | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ( | |
self.model.config.model_type == "qwen2_vl" | |
or self.model.config.model_type == "qwen2_5_vl" | |
): | |
if self.model.config.model_type in {"qwen2_vl", "qwen2_5_vl"}: |
Fixing the chatbot for you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wish I could blame it on a bot 😅
thanks!
if ( | ||
config.model_type == "qwen2_vl" | ||
or config.model_type == "qwen2_5_vl" | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Simpler condition.
This PR adds support for qwen2.5-vl models and currently loads the weights and supports reasonable responses. Opening early for exposure and any feedback.
These changes are dependent on #2943 and must be rebased/merged after it is merged
items
RMSNorm
in vision blocksfullatt_block_indexes
small reproducible example:
script
output