Add loop_controls
feature to minijinja
to handle {% break %}
#2998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the feature
loop_controls
tominijinja
as per minijinja - optional features, as some models as e.g.CohereForAI/c4ai-command-r7b-12-2024
make use of thebreak
statement within the inner loops in the template, which is not supported onminijinja
by default.As of
minijinja
's description of theloop_controls
feature "enables the {% break %} and {% continue %} loop control flow tags."Thanks to @Cyrilvallez for reporting internally!
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@OlivierDehaene OR @Narsil