Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loop_controls feature to minijinja to handle {% break %} #2998

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

alvarobartt
Copy link
Member

What does this PR do?

This PR adds the feature loop_controls to minijinja as per minijinja - optional features, as some models as e.g. CohereForAI/c4ai-command-r7b-12-2024 make use of the break statement within the inner loops in the template, which is not supported on minijinja by default.

As of minijinja's description of the loop_controls feature "enables the {% break %} and {% continue %} loop control flow tags."

Thanks to @Cyrilvallez for reporting internally!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@OlivierDehaene OR @Narsil

@Narsil Narsil merged commit 8a1cfd6 into main Feb 18, 2025
18 of 19 checks passed
@Narsil Narsil deleted the handle-break-in-tool-template branch February 18, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants