change ChatCompletionChunk to align with "OpenAI Chat Completions str… #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaming API"
When stream_options: {"include_usage": true} is included, choices is None only for the last chunk, and usage is always None except for the last chunk.
Signed-off-by: Wang, Yi A <[email protected]>
|
details please refer discussion in vllm-project/vllm#12394 |
Signed-off-by: Wang, Yi A <[email protected]>
|
What's broken otherwise ? Our baseline is if it breaks the OpenAI client we try to fix it (depending on how much it's tying to internals it's sometimes hard to be ISO compatible), and otherwise we try to minimize the amount of bits we send (that are not useful) and therefore we don't send what's not needed. We don't look that much as the actual payload they send/receive as they tend to change them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eaming API"
When stream_options: {"include_usage": true} is included, choices is None only for the last chunk, and usage is always None except for the last chunk.
see https://cookbook.openai.com/examples/how_to_stream_completions#4-how-to-get-token-usage-data-for-streamed-chat-completion-response
@OlivierDehaene OR @Narsil