Pr 3018 ci branch #3028
Closed
Pr 3018 ci branch #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
dacorvo
reviewed
Feb 17, 2025
| export label_extension="-neuron" | ||
| export docker_devices="none" | ||
| export docker_volume="/mnt/cache" | ||
| export runs_on="aws-inf2-8xlarge" |
There was a problem hiding this comment.
You don't actually need these runners just to build the image: it is better to use ubuntu-latest and keep them available for dedicated pipelines that run the tests.
There was a problem hiding this comment.
The CI builds on a custom CPU only runner. This runner is to actually run the CI. docker_devices probably requires the same flag as the README.md suggests.
drbh
commented
Feb 17, 2025
| export docker_volume="/mnt/cache" | ||
| export runs_on="aws-inf2-8xlarge" | ||
| export platform="cpu" | ||
| export extra_pytest="-k test_flash_llama_simple" |
There was a problem hiding this comment.
Note
hardware specific pytest flags can be added here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply reopens #3018 to run CI