make content field optional in Message for role=assistant #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary to keep compatibility with openai. The usage of tgi with openai compatible libraries for function calling was broken.
The streaming API for tool calling now starts when the name is parsed and then send arguments as token are generated and stops properly.
…ction definition type
Narsil
reviewed
Feb 19, 2025
Narsil
reviewed
Feb 19, 2025
| Ok(m.into()) | ||
| } else if m.content.is_none() { | ||
| // For messages requiring content but having none, return error | ||
| return Err(InferError::TemplateError( |
There was a problem hiding this comment.
This is not a TemplateError, this is a UserError.
drbh
force-pushed
the
pr-2954-ci-branch
branch
from
22fa0e1 to
3dd0128
Compare
|
Closing in favor of #3036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.