Skip to content

Conversation

crawftv
Copy link

@crawftv crawftv commented Aug 19, 2025

References the issue I created #1845
#1845

I propose moving the huggingface_hub dependency to the optional testing dependencies to make installs easier and cleaner.

@Narsil
Copy link
Collaborator

Narsil commented Sep 4, 2025

That's not possible.

tokenizers HARD depends on huggingface_hub for the "from_pretrained" function.
It seems the issue you had was with hf-xet, and should be fixed soon. I'll close this PR for now, but let's reopen if there's anything that actually makes this http dependency problematic for other reasons. (I'll admit this dependency is only for a single function, which should be replaceable in 2 lines, but still it would be a huge breaking change to remove it since basically most HF code uses it.)

@Narsil Narsil closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants