Repository navigation
Add Ovis2.5 model support - #47659
sushmanthreddy wants to merge 189 commits into
Conversation
|
Thanks for working on it! We'll pass by a bit later since there are a few other model releases atm 🤗 |
Load official checkpoints through the registered Ovis2.5 WeightRenaming rules instead of materializing a duplicate state dict. Save with save_original_format=False so native Transformers names are serialized, then strictly reload the model and processor without remote code. Normalize the config, tokenizer, processor, and generation metadata for the released 2B and 9B variants. Both variants were validated with complete key coverage, including the tied 2B language head and the separate 9B language head.
Reuse Qwen2-VL packed-patch processing with Ovis2.5's native resize policy and preprocessing defaults. Keep video-only helpers in the video processor and cover native patch ordering directly.
|
@zucchini-nlp I’ve completed an end-to-end review and validation of the changes. Could you please review the PR and let me know if any further changes are needed? |
|
thanks a lot, reviewing tonight or tmrw morning |
zucchini-nlp
left a comment
There was a problem hiding this comment.
Oke, overall looks fine if we can push for even more modular. Especially, I didn't get why the vision block is re-inventing the wheel for some things we already have in QwenVL-family
See my comments 👇🏻 for details, that should help guide you where to copy from
Also, please lmk why we need a conversion script since it looks like we can load from existing remote-code repo
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, ovis2_5 |
|
@vasqu Thanks for the detailed review. I’ve gone through your comments and pushed the updates, including the merge conflict fix. Could you take another look when you have time? I’m still a bit unsure about the Ovis test files, so I’d especially appreciate a close review of their structure and coverage. Please let me know if anything else needs changing. |
|
@sushmanthreddy could we potentially first fix the tests / fast CI? Will try to check when I can but expect a bit of delays |
Fixed the tests @vasqu |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, ovis2_5 |
CI recapDashboard: View test results in Grafana |
|
Anton is off for a week so we will pass by in 1-2 weeks. IPing us agai then pls @sushmanthreddy |
|
sure @zucchini-nlp |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, ovis2_5 |
What does this PR do?
Support Ovis2.5 multimodal models from AIDC-AI.
This PR adds native model support, checkpoint conversion, image and video processing, Auto class registrations, documentation, and tests. Converted checkpoints can be loaded without
trust_remote_code.This continues the work from the closed WIP PR #40321.
Fixes #40841
Who can review?
@zucchini-nlp @Cyrilvallez
Ovis2.5 is available in 2B and 9B variants and supports variable-resolution images, multiple images, video inputs, and multimodal reasoning. Looking forward to your feedback!