Repository navigation
Move the remaining router-masked MoE plans to ep_dispatch_experts - #49607
Open
IlyasMoutawwakil wants to merge 12 commits into
Open
IlyasMoutawwakil wants to merge 12 commits into
IlyasMoutawwakil wants to merge 12 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. Pages changed in this PR: |
IlyasMoutawwakil
changed the base branch from
ep-masked-when-shared-batch
to
ep-passthrough-strategy
October 14, 2026 16:49
This was referenced Oct 14, 2026
IlyasMoutawwakil
force-pushed
the
ep-move-router-plans
branch
from
October 16, 2026 06:50
2b82f8b to
5f5dc05
Compare
IlyasMoutawwakil
force-pushed
the
ep-move-router-plans
branch
from
October 16, 2026 06:51
5f5dc05 to
6ca9df4
Compare
ep_dispatch_expertsep_dispatch_experts
vasqu
approved these changes
Oct 19, 2026
Gemma 4, DiffusionGemma, GraniteMoE-SWA, HY-V4, Inkling and MiMo-V2-Flash call their experts with expert ids like every other experts class, so their EP plans drop `ep_router` + `moe_tp_experts` for `ep_dispatch_experts`, which runs the all-reduce at inference and token dispatch in training. Qwen3-MoE and Mellum stop pointing users at the router-masked plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
IlyasMoutawwakil
force-pushed
the
ep-move-router-plans
branch
from
October 27, 2026 21:49
81e3adf to
ff34d62
Compare
…defaults in the docs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ep_dispatch_expertsep_dispatch_experts
3outeille
approved these changes
Nov 4, 2026
ArthurZucker
approved these changes
Nov 4, 2026
…-move-router-plans
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: beam, diffusion_gemma, gemma4, hy_v4, inkling, mellum, mimo_v2_flash, qwen3_moe |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #49606.
Gemma 4, DiffusionGemma, GraniteMoE-SWA, HY-V4, Inkling and MiMo-V2-Flash still defaulted to the router-masked EP plan:
ep_routeron the router andmoe_tp_expertson the experts. Their experts take(hidden_states, top_k_index, top_k_weights)like every other experts class. So their EP plans move toep_dispatch_experts.With
ep_dispatch_experts, these models:ep_size == tp_size, as before (Expert-parallel implementations forep_dispatch_experts: all-reduce at inference, all-to-all in training #49429);ep_size > tp_size.Changes
ep_routerrule and use"layers.*...experts": "ep_dispatch_experts".Still on
ep_routerafter this PR:ep_dispatch_experts#49613 moves it.#49615 then removes
ep_router.Tests
scipyis missing in the test env)tests/expert_parallel, 2 ranks on gloo🤖 Generated with Claude Code