Repository navigation
[serge] Fix 2 integration tests for model ovis2 failing with output_mismatch (list output differs (2)) - #50233
Open
sergereview[bot] wants to merge 1 commit into
Open
sergereview[bot] wants to merge 1 commit into
sergereview[bot] wants to merge 1 commit into
Conversation
…t_mismatch` (list output differs (2))
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: ovis2 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
reviewed
Nov 2, 2026
Comment on lines
+199
to
+200
| # left padding is required for batched generation when the samples have different lengths | ||
| self.processor.tokenizer.padding_side = "left" |
Member
There was a problem hiding this comment.
my two cents: it is very weird that we keep seeing random failures due to padding side, not the first time 🤔
Could it be smth on tokenizer classes or are we sure that test never passed? Maybe we need some way to catch these random default value changes in test_tokenization or smth if it happens so often
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original CI failure
2 integration tests for modelovis2failing withoutput_mismatch(list output differs (2))tests/models/ovis2/test_modeling_ovis2.py::Ovis2IntegrationTest::test_small_model_integration_test_batch_different_resolutions[multi-gpu] (output_mismatch, seen 21/21)CI traceback —
tests/models/ovis2/test_modeling_ovis2.py::Ovis2IntegrationTest::test_small_model_integration_test_batch_different_resolutionsWhere to watch it:
Relates to #50231
test_small_model_integration_test_batch_different_resolutionsbatches a 1-patch image (320x240, 256 image tokens) with a 5-patch one, so the shorter sample is padded. With the tokenizer's default right padding, generation for that sample starts from a pad token and emits EOS immediately, which is the emptyassistant\noutput in the trace.The test now sets
padding_side = "left"insetUp, as sibling VL integration tests do (e.g.tests/models/hunyuan_vl/test_modeling_hunyuan_vl.py:305), so both samples generate from their real last token.The low-res expectation is updated to the left-padded output: same description of the same dog image, without the
Answer:prefix and two tokens further into the sentence withinmax_new_tokens=20. This is a padding-side change, not hardware drift, so no device key is added.✅ Verified on GPU
serge ran the targeted
@slowtest(s) on a GPU runner and opened this PR only after they passed with this patch. Each targeted test was run 5× on both the pre-patch and patched trees to rule out flakiness — the result held on every run.Possibly related
Existing issues/PRs mentioning
test_small_model_integration_test_batch_different_resolutions(keyword match — not verified to share a root cause):This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:deepseek-ai/DeepSeek-V4.1-Flash-1017:together· 35 LLM turns · 54 tool calls · 243.3s · 1624850 in / 80284 out tokens