Skip to content

Conversation

@kashif
Copy link
Collaborator

@kashif kashif commented Nov 13, 2025

What does this PR do?

Fixes dapo loss type support, but needs to wait for upstream merge and release linkedin/Liger-Kernel#939

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@kashif kashif marked this pull request as draft November 13, 2025 10:47
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif requested a review from lewtun November 22, 2025 13:18
@kashif kashif marked this pull request as ready for review November 22, 2025 13:18
@kashif
Copy link
Collaborator Author

kashif commented Nov 22, 2025

@lewtun would you be able to benchmark this branch for memory usage of grpo trainer?

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this @kashif ! LGTM with a question about adding 1 to logits_to_keep twice. Could you also add your nice plots showing the memory improvement with the Triton loss to the PR description?

Also, do we need to bump the minimum liger version?

@qgallouedec
Copy link
Member

LGTM, it would be nice to have a quick comparison of the profiles, just to get an idea of the extent of the memory reduction.

@kashif
Copy link
Collaborator Author

kashif commented Dec 1, 2025

comparison Red (old) and pink is triton based

W B Chart 01_12_2025, 18_30_08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants