Add optional skills breakdown modal#475
Open
fabiofenoglio wants to merge 11 commits intohugo-themes:mainfrom
Open
Add optional skills breakdown modal#475fabiofenoglio wants to merge 11 commits intohugo-themes:mainfrom
fabiofenoglio wants to merge 11 commits intohugo-themes:mainfrom
Conversation
…n before collapsing
Member
|
@fabiofenoglio Thank you for the PR. Look like a great idea. I will review soon. |
Member
|
Hi @fabiofenoglio, I have started reviewing this PR. We need a better design for the breakdown popup. Probably, more simple but should be useful. I am thinking of removing the circular progress bar entirely. They don't provide any value. We can keep the horizontal progress bar but might make it optional. We need a simple and consistent view for multi-level items. Also, we must consider responsiveness of the popup. I might take few more weeks to come up with any mockup. |
001e28a to
ddbb4bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to propose a feature consisting in a detailed breakdown modal for the skills sections.
Description
This PR adds support for a "breakdown" parameter in the "skills" section.
If present, a dialog will popup when clicking on the skill, presenting a detailed skill breakdown.
The breakdown is highly customizable and can be nested at will.
Each entry of the skill breakdown can have optionally any combination of:
nameandsummarylogoto display an imagepercentageandcolorto display a scaled-down circular progress, similar to the soft skill badges but much smallerprogressto display the skill as a progress bar. IfprogressClassis not provided, the class/color is automatically derived.breakdownlist allowing for arbitrary nestingexpandBreakdownto optionally force the accordion of the children breakdown to be opened by defaultAs a side effect the following would be introduced:
circular-progresscomponent to allow reusing of the circular soft-skill badges in other places, supporting "sm" and "xs" versionsTest Evidence
Attaching a demo animation:

Here's a sample mixed and nested configuration:
Please let me know if you'd like the feature, if the parameters format is ok or if I forgot something like documentation.