Open
Conversation
* Added parameter and return type documentation for initialization methods. * Provided example usage for the `fancyTextViewWithFrame:markupText: method`. Before: ```objc /// The GSFancyText object for this view @Property (nonatomic, retain) GSFancyText* fancyText; /// The content height of the fancyText object. @Property (nonatomic, assign, readonly) CGFloat contentHeight; /** If matchFrameHeightToContent is set to YES, the view frame height will be set to match the content height * every time updateDisplay method is called. * * If it's set to NO, every time we call updateDisplay, only the new width will be used to affect the line height. */ @Property (nonatomic, assign) BOOL matchFrameHeightToContent; /** If it is set to YES, the view frame width will be set to match the content width (if the actually content is narrower than assigned width) * every time updateDisplay method is called. */ @Property (nonatomic, assign) BOOL matchFrameWidthToContent; ``` After: ```objc /// The GSFancyText object for this view. @Property (nonatomic, retain) GSFancyText *fancyText; /// The content height of the fancyText object. @Property (nonatomic, assign, readonly) CGFloat contentHeight; /** Determines whether the view frame height should match the content height. * * If set to YES, the view frame height will be set to match the content height * every time the updateDisplay method is called. * * If set to NO, the new width will be used to affect the line height when updateDisplay is called. */ @Property (nonatomic, assign) BOOL matchFrameHeightToContent; /** Determines whether the view frame width should match the content width. * * If set to YES, the view frame width will be set to match the content width (if the actual content is narrower than the assigned width) * every time the updateDisplay method is called. */ @Property (nonatomic, assign) BOOL matchFrameWidthToContent; ``` * Added spaces between the type and the asterisk in pointer declarations (e.g., `GSFancyText *fancyText_` instead of `GSFancyText* fancyText_`). * Ensured consistent use of indentation and spacing throughout the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
I've listed all my changes, and before and afters in this Hulu repo entitled GrannySmith.
Some of the first things I did were:
Added parameter and return type documentation for initialization methods.
Provided example usage for the
fancyTextViewWithFrame:markupText: method.Before:
After:
Added spaces between the type and the asterisk in pointer declarations (e.g.,
GSFancyText *fancyText_instead ofGSFancyText* fancyText_).Ensured consistent use of indentation and spacing throughout the file.
Cheers,
Michael Mendy