fpm dependency removed

[kt97679]

Latest dpkg-deb got --root-owner-group option which simplifies package build and allows to eliminate fpm dependency in the build process.

[kt97679]

@sjafferali please have a look when you will have a minute. Thanks :)!

[klausfiend]

@kt97679 the fact that dpkg-deb now has the correct dependencies and this now resembles a normal Debian package build suggests to me that this should use an actual cleanroom dpkg build tool like pbuilder or cowbuilder instead of this compromise approach. IMO just stick with fpm because it's not comparable to a cleanroom build, or just bite the bullet and make a proper Debian package -- this looks like a convoluted half-step between the two of them.

[kt97679]

I'm sorry @klausfiend I' don't quite understand your point. Why using pbuilder or cowbuilder is better than using dpkg-deb? At the end of the day we get valid deb package so I think this is totally ok to use dpkg-deb here. I did more research and looks like we don't need --root-owner-group, we can use fakeroot instead.

[klausfiend]

I'm sorry @klausfiend I' don't quite understand your point. Why using pbuilder or cowbuilder is better than using dpkg-deb? At the end of the day we get valid deb package so I think this is totally ok to use dpkg-deb here. I did more research and looks like we don't need --root-owner-group, we can use fakeroot instead.

That's pretty much what tools like pbuilder do -- you're reinventing the wheel here. If you go through the trouble of setting up all the components of a Debian package in the way the specs require and then don't use any of the tools ... I don't see the benefit of then not using fpm, which automatically manages all the complexity introduced with this change, but yet not actually doing things the proper Debian way (e.g., using the debhelper tools).

[kt97679]

I'm sorry @klausfiend there is no introduced complexity, there is reduced one. Building package is now much more straightforward with less moving parts. dependencies and layers.