Do not clone config objects #12

jnv · 2020-12-28T14:29:43Z

Fixes #2.

Also fix docs on passing plugin options via next-compose-plugins.

jnv · 2020-12-28T15:03:19Z

Actually, defaultsDeep doesn't seem to be a correct replacement for deepmerge, because it merges arrays as well: lodash/lodash#2802 (comment)

next-compose-plugins require a nested array to pass plugin-specific options.

jnv · 2020-12-28T15:42:07Z

As explained in #2 (comment) I kept using deepmerge. I have only added clone: false option to fix the experimental warning.

KidkArolis · 2021-01-05T19:53:29Z

Thanks so much!

jnv marked this pull request as draft December 28, 2020 15:03

jnv added 2 commits December 28, 2020 16:38

Fix docs

f98c668

next-compose-plugins require a nested array to pass plugin-specific options.

Set clone: false for deepmerge

4f38183

jnv force-pushed the defaultsdeep branch from 5f13963 to 4f38183 Compare December 28, 2020 15:39

jnv changed the title ~~Use lodash's defaultsDeep for Next config~~ Do not clone config objects Dec 28, 2020

jnv marked this pull request as ready for review December 28, 2020 15:40

KidkArolis merged commit 6ba6d87 into humaans:master Jan 5, 2021

jnv deleted the defaultsdeep branch January 6, 2021 08:13

Provide feedback