Skip to content

Set rootDir explicitly for TS6#608

Merged
wisyhambolu merged 4 commits intomasterfrom
set-rootDir-explicitly-for-TS6
Apr 17, 2026
Merged

Set rootDir explicitly for TS6#608
wisyhambolu merged 4 commits intomasterfrom
set-rootDir-explicitly-for-TS6

Conversation

@wisyhambolu
Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings April 16, 2026 16:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates TypeScript configuration to avoid TypeScript 6 default rootDir behavior changing emitted paths, aligning build/test compilation output with existing expectations.

Changes:

  • Set compilerOptions.rootDir to ./src in tsconfig.json
  • Set compilerOptions.rootDir to ./tests in tsconfig.test.json

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
tsconfig.json Explicitly sets rootDir for main compilation output paths under dist/.
tsconfig.test.json Explicitly sets rootDir for test compilation/transforms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tsconfig.test.json Outdated
@wisyhambolu wisyhambolu force-pushed the set-rootDir-explicitly-for-TS6 branch from 636a598 to 6e8c105 Compare April 16, 2026 17:10
Copy link
Copy Markdown
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wisyhambolu wisyhambolu merged commit 19f9b3b into master Apr 17, 2026
4 checks passed
@wisyhambolu wisyhambolu deleted the set-rootDir-explicitly-for-TS6 branch April 17, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants