fix(types): fix FilterPredicate type #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
force-pushed
the
boneskull/filter-type
branch
from
ece56f4
to
a596433
Compare
This changes the type of `FilterPredicate` so that it aligns with reality.
boneskull
force-pushed
the
boneskull/filter-type
branch
from
a596433
to
5ac1110
Compare
boneskull
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the type of
FilterPredicateso that it aligns with reality.Background: the
filterparam toiterator(filter)was not being called with[Node, number, Node[]]as per theFilterPredicatetype, but rather[{node: Node, parent?: Node, phase: TraversalPhase}, number, {node: Node, parent?: Node, phase: TraversalPhase}[]].This changes the type to match what it's actually called with. Changing the function to match the type would be a breaking change (and probably kind of weird to implement).