Skip to content

Conversation

@technoir42
Copy link

Volk is an optional component on macOS, whereas on Windows and Linux it's installed by default.
Since it's tiny, I'd just install it by default for parity between OS.

@technoir42
Copy link
Author

@humbletim can you take a look please at this one-liner

echo "recognized zip layout 'vulkan_sdk.zip' ${InstallVulkan}.app/Contents" >&2
local sdk_temp=${VULKAN_SDK}.tmp
sudo ${InstallVulkan}.app/Contents/MacOS/${InstallVulkan} --root "$sdk_temp" --accept-licenses --default-answer --confirm-command install
sudo ${InstallVulkan}.app/Contents/MacOS/${InstallVulkan} --root "$sdk_temp" --accept-licenses --default-answer --confirm-command install com.lunarg.vulkan.volk
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@humbletim humbletim self-requested a review August 4, 2025 22:58
Copy link
Owner

@humbletim humbletim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

i want to run a few more tests to confirm specifying optional components this way doesn't inadvertently reduce default component selections -- but otherwise including volk this way seems reasonable enough to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants