-
-
Notifications
You must be signed in to change notification settings - Fork 206
(refactor) upgraded streamlit to 1.40.0 and refactored to use native streamlit pages instead of st_pages #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) upgraded streamlit to 1.40.0 and refactored to use native streamlit pages instead of st_pages #246
Conversation
|
@cardosofede could you kindly review this? |
|
@YesYouKenSpace hey! thanks for the contribution. actually I wasn't updating streamlit since the react components weren't working with the new update. did u test them? |
|
Hello @cardosofede i have tested from config creation to bot deployment. The other pages are appearing fine too. |
|
@rapcmia @nikspz @david-hummingbot will be good to test |
|
btw @YesYouKenSpace I'm not that involved with streamlit lately but if it's possible to make everything more async so the indicators can be updated in real time, now with AI and css we can make it look really nice and get rid of the react components, idk what do you think... |
I just learnt streamlit actually. Do you mean remove the rewct component and depend on streamlit completely? I think there are many updates to streamlit we could use to improve responsiveness but upgrading it will be the first step. I could not upgrade it to the laatest version at one go as it causes a lot of changed lines and i could not get it to work so was planning to do this incrementally. And also with a smaller PR see if you guys are willing to let me contribute
These changes will affect the dashboard too? |
|
yes the changes will affect dashboard too |
Okay i can refactor after you merge your change. |
…streamlit pages instead of st_pages
76f7811 to
7010585
Compare
cardosofede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge it and start from it for the refactor
No description provided.