Skip to content

Conversation

@YesYouKenSpace
Copy link
Contributor

No description provided.

@YesYouKenSpace
Copy link
Contributor Author

@cardosofede could you kindly review this?

@cardosofede
Copy link
Contributor

@YesYouKenSpace hey! thanks for the contribution. actually I wasn't updating streamlit since the react components weren't working with the new update. did u test them?

@YesYouKenSpace
Copy link
Contributor Author

Hello @cardosofede i have tested from config creation to bot deployment. The other pages are appearing fine too.

@cardosofede
Copy link
Contributor

@rapcmia @nikspz @david-hummingbot will be good to test

@david-hummingbot david-hummingbot self-assigned this May 26, 2025
@cardosofede
Copy link
Contributor

btw @YesYouKenSpace I'm not that involved with streamlit lately but if it's possible to make everything more async so the indicators can be updated in real time, now with AI and css we can make it look really nice and get rid of the react components, idk what do you think...
Also I can't merge your PR since I'm in the middle of a transition into a more robust backend api with a custom MQTT handler and refactor of routes + db inclusion to store balances and bot runs

@YesYouKenSpace
Copy link
Contributor Author

btw @YesYouKenSpace I'm not that involved with streamlit lately but if it's possible to make everything more async so the indicators can be updated in real time, now with AI and css we can make it look really nice and get rid of the react components, idk what do you think...

I just learnt streamlit actually. Do you mean remove the rewct component and depend on streamlit completely? I think there are many updates to streamlit we could use to improve responsiveness but upgrading it will be the first step. I could not upgrade it to the laatest version at one go as it causes a lot of changed lines and i could not get it to work so was planning to do this incrementally. And also with a smaller PR see if you guys are willing to let me contribute

Also I can't merge your PR since I'm in the middle of a transition into a more robust backend api with a custom MQTT handler and refactor of routes + db inclusion to store balances and bot runs

These changes will affect the dashboard too?

@cardosofede
Copy link
Contributor

yes the changes will affect dashboard too

@YesYouKenSpace
Copy link
Contributor Author

yes the changes will affect dashboard too
-- @cardosofede

Okay i can refactor after you merge your change.

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge it and start from it for the refactor

@cardosofede cardosofede merged commit dadd9c1 into hummingbot:main Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants