Skip to content

Conversation

@cardosofede
Copy link
Contributor

No description provided.

@rapcmia rapcmia self-requested a review August 4, 2025 13:53
@rapcmia
Copy link
Contributor

rapcmia commented Aug 5, 2025

  • Setup with dashboard + emqx ✅
  • Setup on source ✅

Run tests using hummingbot-api fastify

  • Run GET /controllers/{controller_type}/{controller_name}/config/template
    • Test with invalid controller names returns controller configuration class for 'test only' not found
    • All categories and controllers generated except generic’s basic_order_example and basic_order_open_close_example
      image
  • Run POST /controllers/{controller_type}/{controller_name}/config/validate
    • When testing the endpoint, use the results from /config/template
    • Got and error "'dict' object has no attribute 'strip'
      image
      • To reproduce: Get the response from any controller from /config/template and use it to validate e.g directional_trading.dman_v3

@rapcmia rapcmia moved this to Under Review in Pull Request Board Aug 5, 2025
@cardosofede
Copy link
Contributor Author

@david-hummingbot @rapcmia test this wiht the mcp, on my end is working

@david-hummingbot
Copy link
Contributor

I checked this with MCP and it's not able to reproduce the error - I think it's the way the config results are pasted.
Running the CURL command manually returns "Configuration is valid"

image

Had Gemini test through MCP to see if it can reproduce but it's not able to -

image

@cardosofede
Copy link
Contributor Author

let's proceed

@david-hummingbot david-hummingbot merged commit 164cb11 into main Aug 8, 2025
@rapcmia rapcmia moved this from Under Review to Development 2.8.0 in Pull Request Board Aug 11, 2025
@rapcmia rapcmia moved this from Development 2.8.0 to Release 2.8.0 in Pull Request Board Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants