Add first implementation of positionless #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only supporting forward-iterator case
…tion is always checked.
RishabhRD
reviewed
Nov 30, 2025
Member
RishabhRD
left a comment
RishabhRD
left a comment
There was a problem hiding this comment.
Few inline comments.
I don't see toprev and tonext operations. I needed them to implement algorithms in pure positionless way. Are those not needed for our purposes here?
BTW I need to say, I saw a good C++ codebase after a long time. Really thanks for that 😅.
Collaborator
Author
Added implementation for them. Thank you very much! |
dabrahams
reviewed
Dec 1, 2025
naveen-seth
reviewed
Dec 2, 2025
Co-authored-by: Naveen Seth Hanig <[email protected]> Co-authored-by: Dave Abrahams <[email protected]>
naveen-seth
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
positionlessclass an its operations.Add unit tests to ensure that everything works.