-
Notifications
You must be signed in to change notification settings - Fork 303
feat: add custom ingestion key via INGESTION_API_KEY #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 662cc02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
83ed8c1
to
43658f7
Compare
Stably Runner - Test Suite - 'Smoke Test'Test Suite Run Result: 🟢 Success (4/4 tests passed) [dashboard] This comment was generated from stably-runner-action |
@@ -15,6 +15,7 @@ export const EXPRESS_SESSION_SECRET = (env.EXPRESS_SESSION_SECRET || | |||
DEFAULT_EXPRESS_SESSION) as string; | |||
export const FRONTEND_URL = (env.FRONTEND_URL || | |||
DEFAULT_FRONTEND_URL) as string; | |||
export const INGESTION_API_KEY = env.INGESTION_API_KEY ?? ''; | |||
export const HYPERDX_API_KEY = env.HYPERDX_API_KEY as string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's already a HYPERDX_API_KEY
... is this different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they serve different purposes. HYPERDX_API_KEY
instruments the HyperDX application to send telemetry. INGESTION_API_KEY
allows a user to set their own api key programmatically
Closes HDX-2283
This adds an environment variable
INGESTION_API_KEY
that can be set by the user. This apiKey will be valid and accepted by the Otel collector. It is in addition to the autogenerated apiKey and will not show in the team settings apiKey section.