Skip to content

fix: Show threshold chart when creating alerts for unsaved search #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

fix: Show threshold chart when creating alerts for unsaved search #704

merged 2 commits into from
Mar 25, 2025

Conversation

ernestii
Copy link
Contributor

@ernestii ernestii commented Mar 22, 2025 •
edited
Loading

Remove dependency on savedSearch.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6754242

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestii ernestii changed the base branch from main to v2 March 22, 2025 02:08
@ernestii ernestii changed the title ernest/hdx 1474 create alert doesnt show threshold preview for new searches fix: Show threshold chart when creating alerts for unsaved search Mar 22, 2025
@ernestii ernestii marked this pull request as ready for review March 22, 2025 02:08
wrn14897
wrn14897 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome fix!

@kodiakhq kodiakhq bot merged commit ca3d8fe into v2 Mar 25, 2025
4 checks passed
@kodiakhq kodiakhq bot deleted the ernest/hdx-1474-create-alert-doesnt-show-threshold-preview-for-new-searches branch March 25, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrn14897 wrn14897 wrn14897 approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ernestii @wrn14897