Conversation
|
ernestii
force-pushed
the
ernest/hdx-1498-lots-of-results-tables-cant-open-event-details-on-click
branch
2 times, most recently
from
4dac540 to
258eec7
Compare
| // Compress and decompress the value to save space in the URL | ||
| const deflateParser = createParser({ | ||
| parse: (value: string) => { | ||
| return JSON.parse(LZString.decompressFromBase64(value)) as SidePanelStack; |
There was a problem hiding this comment.
I think we should keep them user readable, that way it's easy to interact programmatically as well (people who build URLs dynamically from retool and other internal platforms for example)
ernestii
force-pushed
the
ernest/hdx-1498-lots-of-results-tables-cant-open-event-details-on-click
branch
2 times, most recently
from
f9a02b8 to
1f81214
Compare
ernestii
force-pushed
the
ernest/hdx-1498-lots-of-results-tables-cant-open-event-details-on-click
branch
from
1f81214 to
0e519bb
Compare
teeohhem
left a comment
teeohhem
left a comment
There was a problem hiding this comment.
Clean approach. Tested locally and things worked as expected.
A few notes for later (will create tickets)
- If you find yourself clicking into many rows (surrounding context is an example), it can take as many clicks to completely close the side panels completely. A "close all" button might be nice.
- Existing bookmarks with tabs may not work (I don't think we really care)
…en-event-details-on-click
wrn14897
left a comment
wrn14897
left a comment
There was a problem hiding this comment.
Pushed changes to update all k8s dashboard related components
wrn14897
left a comment
wrn14897
left a comment
There was a problem hiding this comment.
One issue I noticed is that the row side panels keep stacking when I use 'j' and 'k' to navigate between rows, and there's no way to close all the panels at once. Also I'm curious what's the best way to handle nested side panels? (ex: k8s dashboard)
teeohhem
left a comment
teeohhem
left a comment
There was a problem hiding this comment.
Reviewing further and discussing. Don't merge yet
4 participants
No description provided.