fix: remove several source change forms throughout the log drawer #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f1fb57c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
knudtty
commented
Apr 1, 2025
| tags, | ||
| mainContent = '', | ||
| mainContentHeader, | ||
| date, | ||
| severityText, | ||
| }: { | ||
| sourceId: string; |
There was a problem hiding this comment.
sourceId was only used for the TableSourceForm
| const [ | ||
| sourceFormModalOpened, | ||
| { open: openSourceFormModal, close: closeSourceFormModal }, | ||
| ] = useDisclosure(false); |
There was a problem hiding this comment.
All solely related to opening/closing source form
teeohhem
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: HDX-1528
Removing TableSourceForm from locations where it doesn't make a lot of sense to exist. It's still available under source edit and team settings.